Uploaded image for project: 'Social Justice Repair Kit'
  1. Social Justice Repair Kit
  2. SJRK-417

Remove ESLint "global" declarations in each file

    XMLWordPrintable

    Details

      Description

      What needs doing:

      Remove all references to ESLint global variables which are already defined in configuration files. Namely "fluid" and "sjrk". "jqUnit" and a small handful of other values are defined as well, but not commonly enough to add to the
      overall config file for the project.

       

      Why it needs doing:

      As highlighted by this review feedback by Justin Obara on the SJRK-289 pull request, the ESLint global variable declarations which are present in many files are repetitive and can instead be defined just once in the .eslintrc.json file.

      Previous attempts at this ran afoul of the linter, but the configuration and tools now seem to agree (at time of filing)

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            gmoss Gregor Moss
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: