Uploaded image for project: 'Social Justice Repair Kit'
  1. Social Justice Repair Kit
  2. SJRK-272

Custom theme script loading may cause race condition

    XMLWordPrintable

    Details

      Description

      The current method of loading custom theme CSS files (via sjrk.storyTelling.loadCustomThemeFiles) can potentially lead to a race condition. The files are loaded via a call to [$.getScript|https://api.jquery.com/jQuery.getScript/], which will call its "success" callback after the script is loaded but not necessarily executed. The time between this loading and execution could therefore cause problems.

      Look into how probable and/or possible this race condition is, and address it accordingly.

      For further context on this issue, please refer to the discussion in the pull request review for SJRK-268https://github.com/fluid-project/sjrk-story-telling/pull/39

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            gmoss Gregor Moss
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Dates

              Created:
              Updated: