Uploaded image for project: 'Fluid Infusion'
  1. Fluid Infusion
  2. FLUID-5886

Model listeners attached to the same component are not deduplicated by namespace

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Blocker
    • Resolution: Fixed
    • Affects Version/s: 2.0
    • Fix Version/s: None
    • Component/s: Data Binder
    • Labels:
      None

      Description

      FLUID-5865 introduced support for namespaces and constraint-based priorities for model listeners. Unfortunately the current implementation will surprise users who expect (in accordance with the documentation at https://github.com/fluid-project/infusion-docs/pull/84/files ) that model listeners attached to the same ChangeApplier will be deduplicated by namespace.

      We have two opportunities to do this - firstly, when adding the listeners in that.modelChanged.addListener (the logical place - unfortunately the "namespace" element in "spec" is ignored here), and secondly, as a last-ditch point when collecting outgoing changes in fluid.storeExternalChange - where we could (and I believe used to) apply the spec's "namespace" to the algorithm composing the "keyString". Unfortunately, we do neither.

      Given this is contrary to the supplied docs and all expected behaviour, we should consider this a release blocker for 2.0.

        Attachments

          Activity

            People

            Assignee:
            antranig Antranig Basman
            Reporter:
            antranig Antranig Basman
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: