Uploaded image for project: 'Fluid Infusion'
  1. Fluid Infusion
  2. FLUID-5593

After speaking has finished, the model is reset, and wipes out any custom model properties.

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.9
    • Component/s: Self Voicing
    • Labels:
      None

      Description

      The handleEnd method, which is called after speaking has finished, resets the model by replacing it with false values. However since this replaces the model, if there are custom properties added to the model (e.g. enabled used by the enactor), they will be removed.

      current method.

      fluid.textToSpeech.handleEnd = function (that) {
      if (!that.queue.length) {
      that.applier.change("",

      { speaking: false, pending: false, paused: false }

      );
      }
      };

      The correct action should be to only change the values it cares about. Perhaps by merging these values with the current model and passing this into to the applier call.

      fluid.textToSpeech.handleEnd = function (that) {
      var resetValues =

      { speaking: false, pending: false, paused: false }

      ;

      if (!that.queue.length) {
      var newModel = $.extend({}, that.model, resetValues);
      that.applier.change("", newModel);
      }
      };

        Attachments

          Activity

            People

            Assignee:
            Unassigned Unassigned
            Reporter:
            jobara Justin Obara
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: