FLUID-5457: Supplying a custom theme can cause the default preference option to not be properly styled

Metadata

Source
FLUID-5457
Type
Bug
Priority
Major
Status
Closed
Resolution
Fixed
Assignee
N/A
Reporter
Justin Obara
Created
2014-06-27T13:43:04.247-0400
Updated
2014-10-21T15:01:02.865-0400
Versions
  1. 1.5
Fixed Versions
N/A
Component
  1. Prefs Framework
  2. UIEnhancer
  3. UI Options

Description

When a default theme is provided it is used in place of the standard "fl-theme-prefsEditor-default". However, there are specific styles applied to "fl-theme-prefsEditor-default" to properly style the colour and contrast adjuster option for it.

http://build.fluidproject.org/infusion/tests/manual-tests/html/SomeKindOfNews.html

This manual test uses a custom default theme. Since it didn't supply the correct styling, the cross out effect is missing. Additionally the default option picks up the style of whichever theme is activated.

Attachments

Comments

  • Justin Obara commented 2014-06-27T13:43:55.986-0400

    screenshot.png shows the default option styled the same as the light-grey-dark-grey option

  • Justin Obara commented 2014-06-27T13:44:43.839-0400

    joanna vass should the default option always be a black on white with a crossout or should it take the style of whatever the integrator specified theme is?

  • Justin Obara commented 2014-10-09T13:42:29.711-0400

    Being addressed in the FLUID-5469 work.

  • Justin Obara commented 2014-10-10T13:37:39.934-0400

    Submitted a pull request https://github.com/fluid-project/infusion/pull/565

  • Cindy Li commented 2014-10-21T15:00:58.861-0400

    The pull request has been merged into the project repo @ e90b1a875d9abbd586ff4b0cb6dbe2a0f9a2149d