Uploaded image for project: 'Fluid Infusion'
  1. Fluid Infusion
  2. FLUID-4794

the framework's progressive enhancement support should include an API for clients to be able to register their own feature checking functions

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 1.5
    • Component/s: UIEnhancer
    • Labels:
      None

      Description

      https://github.com/fluid-project/infusion/blob/master/src/webapp/framework/enhancement/js/ProgressiveEnhancement.js

      Current ProgressiveEnhancement implementation does not allow developers to add their own features or extend an existing feature check (fluid.browser)

      Currently videoPlayer has a copy paste code taken from the ProgressiveEnhancement implementation in order to add check for HTML5 and browser full screen support.
      https://github.com/fluid-project/videoPlayer/blob/master/js/VideoPlayer.js#L28-50

      In this particular example a new set of features is being defined and then merged into staticEnvironment. The proper way is to reuse ProgressiveEnhancement.

        Attachments

          Activity

            People

            Assignee:
            jobara Justin Obara
            Reporter:
            anovak Alexey Novak
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: