Uploaded image for project: 'Fluid Infusion'
  1. Fluid Infusion
  2. FLUID-3837

Clean up Uploader's markup

    XMLWordPrintable

Details

    • Improvement
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 0.3, 0.4beta1, 0.4, 0.5beta1, 0.5, 0.6beta1, 0.6, 0.7, 0.8, 0.8.1, 1.0, 1.1, 1.1.1, 1.1.2, 1.1.3, 1.2beta1, 1.2, 1.2.1, 1.3
    • 1.3.1
    • Uploader
    • None

    Description

      Uploader's markup is more complex and less semantic than it could be. For example, right now there are 3 tables being used:

      1) A 1 row, 3 cols table for the values "file name, size, space". It has the caption "File Queue"
      2) A dynamic data table with no caption, 3 cols. It holds the info of the uploaded files
      3) A 1 row, 2 cols table for the footer. The first col has the # files/total size data, and the second has the browse file input.

      I'd like to suggest an alternative:

      • 1 data table, with both the header information and the data
      • the footer as a plain old <div> tag, styled with css

      I'm guessing one reason it was done this way was to make the data scrollable but have a fixed header. We can still achieve this with CSS, and also keep the semantic connection of column headers to data.

      Attachments

        1. uploader_scrollto.patch
          32 kB
          heidi valles
        2. uploader_scroller.patch
          25 kB
          heidi valles
        3. uploader_markup2.patch
          21 kB
          heidi valles
        4. scrollable_unit_test-b.patch
          2 kB
          heidi valles
        5. scrollable_unit_test.patch
          2 kB
          heidi valles
        6. jquery.scrollTo.js
          8 kB
          heidi valles
        7. FLUID-3837-j-cleanup.patch
          20 kB
          heidi valles
        8. FLUID-3837-i.patch
          29 kB
          heidi valles
        9. FLUID-3837-h.patch
          28 kB
          heidi valles
        10. FLUID-3837-g.patch
          26 kB
          heidi valles
        11. FLUID-3837-f.patch
          34 kB
          Colin Clark
        12. FLUID-3837-e.patch
          35 kB
          Colin Clark

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. FLUID-4029 Progress width calculation doesn't include container's padding

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          is depended on by

          Bug - A problem which impairs or prevents the functions of the product. FLUID-4060 Scroller appears after selecting last file in queue

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Task - A task that needs to be done. FLUID-4037 Review new scrolling table styles and add to FSS demo

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed
          relates to

          Bug - A problem which impairs or prevents the functions of the product. FLUID-3878 Improve Uploader's error messages, such as when selected files exceed fileQueueLimit

          • Critical - Crashes, loss of data, severe memory leak.
          • Closed

          Bug - A problem which impairs or prevents the functions of the product. FLUID-4061 Scrolling while uploading

          • Major - Major loss of function.
          • Closed

          Activity

            People

              colin Colin Clark
              heidi heidi valles
              Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: