ENGAGE-107: Engage should use a single app/servlet approach to reduce duplication among handlers and resolve problems with URL routing.

Metadata

Source
ENGAGE-107
Type
Bug
Priority
Blocker
Status
Closed
Resolution
Fixed
Assignee
Colin Clark
Reporter
Colin Clark
Created
2009-10-05T20:58:38.000-0400
Updated
2009-11-03T11:56:03.000-0500
Versions
N/A
Fixed Versions
  1. 0.1
Component
  1. Artifact View
  2. Browse
  3. Kettle

Description

At the moment, Engage is structured awkwardly, causing problems with URL routing and more. We register each Engage handler (artifact View, browse, and each of their couch data feeds) as separate servlets in web.xml, then creating separate Kettle apps for each.

In practice, we should have a single Kettle app for the whole of Engage, and each of the handler logic should be initialized by the app or the framework.

Mounting shared resources such as Infusion or Engage Client should also be done once in the App, not in each handler init.

Attachments

Comments

  • Colin Clark commented 2009-10-05T21:01:50.000-0400

    Here are two patches, one for the kettle directory and one for engage, which implement a nearly-working version of this fix.

  • Justin Obara commented 2009-10-06T13:30:59.000-0400

    Bug Parade Engage 0.1

  • Colin Clark commented 2009-10-06T14:24:24.000-0400

    This issue should also address issues of duplication within Engage, including things like the fact that Browse and Artifact have very similar, yet separate code.

  • Colin Clark commented 2009-10-09T18:32:31.000-0400

    This issue was resolved by my commits to engage-server and -client at r8258 and 8259, with subsequent tweaks from Yura and Antranig.

  • Justin Obara commented 2009-11-03T11:56:03.000-0500

    Closed as per previous comment