Fluid Infusion

Clean up Uploader code for 0.8 release

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.8
  • Component/s: Uploader
  • Labels:
    None

Description

Clean up Uploader code for 0.8 release

- necessary refactoring of code
- removal of gears related files

Attachments

  1. Text File
    FLUID-2219.patch
    12/Feb/09 6:19 PM
    10 kB
    Colin Clark
  2. Text File
    FLUID-2219b.patch
    13/Feb/09 10:41 AM
    12 kB
    Justin Obara

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Obara added a comment -
Bug Parade 0.8 release
Show
Justin Obara added a comment - Bug Parade 0.8 release
Hide
Permalink
Colin Clark added a comment -
Here's a patch with the removal of the Gears-related code from uploader, as well as a tweak to one test that was using the Gears code.
Show
Colin Clark added a comment - Here's a patch with the removal of the Gears-related code from uploader, as well as a tweak to one test that was using the Gears code.
Hide
Permalink
Eli Cochran added a comment -
I've reviewed the patch and the results. Looks good to go.
Show
Eli Cochran added a comment - I've reviewed the patch and the results. Looks good to go.
Hide
Permalink
Justin Obara added a comment -
added an updated patch (FLUID-2219b.patch), adding the removal of the gears related js files from the head of DemoUploadManager-test.html. Leaving these script tags in, causes errors in Opera.
Show
Justin Obara added a comment - added an updated patch (FLUID-2219b.patch), adding the removal of the gears related js files from the head of DemoUploadManager-test.html. Leaving these script tags in, causes errors in Opera.
Hide
Permalink
Colin Clark added a comment -
I've reviewed Justin's patch, extended it to also remove this files from Uploader.html, and will commit.
Show
Colin Clark added a comment - I've reviewed Justin's patch, extended it to also remove this files from Uploader.html, and will commit.
Hide
Permalink
Colin Clark added a comment -
I've removed Gears-related code from trunk. You can still see it in action in the uploader2 directory of the sandbox.
Show
Colin Clark added a comment - I've removed Gears-related code from trunk. You can still see it in action in the uploader2 directory of the sandbox.
Hide
Permalink
Justin Obara added a comment -
Verified fix using:

FF3, FF2, Opera 9.5, Safar 3.1 (Mac OS 10.5)
IE 6, FF3 (Win XP)
Show
Justin Obara added a comment - Verified fix using: FF3, FF2, Opera 9.5, Safar 3.1 (Mac OS 10.5) IE 6, FF3 (Win XP)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for The FLUID Project. Try JIRA - bug tracking software for your team.