Fluid Infusion

Paged contents not displayed in renderer version

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.8
  • Component/s: Pager
  • Labels:
    None
  • Environment:
    FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
    FF2, FF3, IE6, IE7, Opera 9.5 (Win XP)
    FF3, IE7 (Win Vista)
    FF3, IE6 (Win 2000)

Description

Paged contents not displayed in renderer version

Steps to reproduce:

1) Open the renderer version of pager:
http://build.fluidproject.org/fluid/sample-code/pager/renderer/pager-render.html#

Notice that the paged contents are not displayed

An error is thrown.

Error: cellRoot is not defined
Line: 225
File: Pager.js

Issue Links

Activity

Hide
Justin Obara added a comment -
Bug Parade 0.8 release
Show
Justin Obara added a comment - Bug Parade 0.8 release
Hide
Antranig Basman added a comment -
New pager architecture using "columnDefs", cellRoot -> dataOffset. All versions of pager now working again
Show
Antranig Basman added a comment - New pager architecture using "columnDefs", cellRoot -> dataOffset. All versions of pager now working again
Hide
Colin Clark added a comment -
I've reviewed this code. There are some aspects that could use some TLC: JSLinting, lack of substantial new unit tests, some deep nesting that could be flattened to improve readability. Nonetheless, this is a lot of great new functionality and it works fairly well.

This component has undergone a great deal of change, both architecturally and in terms of functionality. It's probably not quite ready to come out of "Preview" status for 0.8, but these changes and fixes are definitely worth shipping. +1 for inclusion in Infusion 0.8.
Show
Colin Clark added a comment - I've reviewed this code. There are some aspects that could use some TLC: JSLinting, lack of substantial new unit tests, some deep nesting that could be flattened to improve readability. Nonetheless, this is a lot of great new functionality and it works fairly well. This component has undergone a great deal of change, both architecturally and in terms of functionality. It's probably not quite ready to come out of "Preview" status for 0.8, but these changes and fixes are definitely worth shipping. +1 for inclusion in Infusion 0.8.
Hide
Justin Obara added a comment -
Verified fix using:

FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5)
FF3, IE6 (Win XP)
Show
Justin Obara added a comment - Verified fix using: FF2, FF3, Opera 9.5, Safari 3 (Mac OS 10.5) FF3, IE6 (Win XP)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved: