Fluid Infusion

Ensure graceful degradation for "unsupported" browsers

Details

  • Type: Bug Bug
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: 0.6
  • Fix Version/s: 0.7
  • Component/s: Uploader
  • Labels:
    None

Description

Ensure graceful degradation for "unsupported" browsers

You can view the uploader compatibility chart on the wiki
http://wiki.fluidproject.org/display/fluid/Uploader+Compatibility+Chart

Attachments

  1. Text File
    FLUID-2073.a.patch
    08/Jan/09 12:17 PM
    1.0 kB
    Eli Cochran
  2. Text File
    FLUID-2073.b.patch
    09/Jan/09 9:50 AM
    1.0 kB
    Colin Clark

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Obara added a comment -
Bug Parade 0.7 release
Show
Justin Obara added a comment - Bug Parade 0.7 release
Hide
Permalink
Eli Cochran added a comment -
Very simple test for IE and Flash 9 defaulting to standard http upload. Doesn't feel that we need anything more flexible or slick considering the temporary-ness of this fix.
Show
Eli Cochran added a comment - Very simple test for IE and Flash 9 defaulting to standard http upload. Doesn't feel that we need anything more flexible or slick considering the temporary-ness of this fix.
Hide
Permalink
Colin Clark added a comment -
Here's a trivial variant on Eli's FLUID-2073.a.patch. This is entirely cosmetic; I have verified that both patches work as expected.

This patch removes the !<, which is the same as >. It removes on unneeded set of brackets. Two comments are added for clarity. The FlashMajorVersion variable was renamed flashVersion to use consistent casing and reflect the same variable name used in the SWFUploadSetupDecorator.

It's all stylistic, and super-trivial. Great patch from Eli.
Show
Colin Clark added a comment - Here's a trivial variant on Eli's FLUID-2073.a.patch. This is entirely cosmetic; I have verified that both patches work as expected. This patch removes the !<, which is the same as >. It removes on unneeded set of brackets. Two comments are added for clarity. The FlashMajorVersion variable was renamed flashVersion to use consistent casing and reflect the same variable name used in the SWFUploadSetupDecorator. It's all stylistic, and super-trivial. Great patch from Eli.
Hide
Permalink
Eli Cochran added a comment -
Committed the FLUID-2073.b.patch. Looks good. Thanks for the tweaks!
Show
Eli Cochran added a comment - Committed the FLUID-2073.b.patch. Looks good. Thanks for the tweaks!
Hide
Permalink
Eli Cochran added a comment -
Should have mentioned explicitly what this fix does.

In all supported browsers except IE the Uploader will show up with either Flash 9 or with Flash 10.
In the IEs, Uploader will only show up with Flash 10.

Otherwise in all cases, the user will be presented with a standard http file upload form element.
Show
Eli Cochran added a comment - Should have mentioned explicitly what this fix does. In all supported browsers except IE the Uploader will show up with either Flash 9 or with Flash 10. In the IEs, Uploader will only show up with Flash 10. Otherwise in all cases, the user will be presented with a standard http file upload form element.
Hide
Permalink
Justin Obara added a comment -
Verified using:

IE 6, IE 7 (Win XP , Flash 10 and Flash 9)
IE 7 (Win Vista, Flash 9)
Show
Justin Obara added a comment - Verified using: IE 6, IE 7 (Win XP , Flash 10 and Flash 9) IE 7 (Win Vista, Flash 9)

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for The FLUID Project. Try JIRA - bug tracking software for your team.