Fluid Infusion

Prepare progressive enhancement-related code for release

Details

  • Type: Sub-issue Sub-issue
  • Status: Closed Closed
  • Priority: Blocker Blocker
  • Resolution: Fixed
  • Affects Version/s: None
  • Fix Version/s: 0.6
  • Component/s: Uploader
  • Labels:
    None

Description

A couple of little tasks to ensure that the recent progressive enhancement-related code is ready for release:

* link against an unminified version of swfobject.js
*remove the unused swfupload-swfobject.js file
* ensure that the licenses are correctly articulated
* update the build scripts to include swfobject.js and ProgressiveEnhancement.js

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Justin Obara added a comment -
Bug Parade 0.6 release
Show
Justin Obara added a comment - Bug Parade 0.6 release
Hide
Permalink
Colin Clark added a comment -
Here's a patch that does the following:

1. Removes the minified version of swfobject.js in favour of the unminified version
2. Updates the build scripts to copy the correct licenses and include ProgressiveEnhancement.js along with swfobject.js
3. Fixes a minor bug in the order of library inclusion in Fluid-all.js
4. Removes swfupload.swfobject.js, which is not used in Uploader 2
5. License renaming for swfuploader and swfobject

Apologies for the size of this patch, but you'll notice that the vast majority of it is the addition and removal of the swfobject files.
Show
Colin Clark added a comment - Here's a patch that does the following: 1. Removes the minified version of swfobject.js in favour of the unminified version 2. Updates the build scripts to copy the correct licenses and include ProgressiveEnhancement.js along with swfobject.js 3. Fixes a minor bug in the order of library inclusion in Fluid-all.js 4. Removes swfupload.swfobject.js, which is not used in Uploader 2 5. License renaming for swfuploader and swfobject Apologies for the size of this patch, but you'll notice that the vast majority of it is the addition and removal of the swfobject files.
Hide
Permalink
Justin Obara added a comment - - edited
Quote from Antranig's code reivew comment on the fluid-work list

"Hi there - I have looked at this patch, and it appears benign to me.

Cheers,
A."
Show
Justin Obara added a comment - - edited Quote from Antranig's code reivew comment on the fluid-work list "Hi there - I have looked at this patch, and it appears benign to me. Cheers, A."
Hide
Permalink
Justin Obara added a comment -
Verified fix.

Tested no js condition using
FF2 and FF3 (Win XP)
Show
Justin Obara added a comment - Verified fix. Tested no js condition using FF2 and FF3 (Win XP)
Hide
Permalink
Justin Obara added a comment - - edited
re-openned issue to edit a comment
Show
Justin Obara added a comment - - edited re-openned issue to edit a comment

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
    Resolved:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for The FLUID Project. Try JIRA - bug tracking software for your team.