Fluid Infusion

When a user tries to add an invalid file (e.g. too large) to the Uploader, it is silently rejected

Details

  • Type: Bug Bug
  • Status: Reopened Reopened
  • Priority: Critical Critical
  • Resolution: Unresolved
  • Affects Version/s: 1.0, 1.1, 1.1.1, 1.1.2, 1.2, 1.3
  • Fix Version/s: None
  • Component/s: Uploader
  • Labels:
    None
  • Environment:
    All A-Grade browsers

Description

In Uploader, browse for a file that is larger than the 20MB limit, and click OK

Notice: that when the dialog dismisses that there is no message that the file was not added to your file queue.

Fix will need to account for both files that fail because of file size, type, or queue limit.

Issue Links

This issue depends on:
FLUID-3878 Improve Uploader's error messages, such as when selected files exceed fileQueueLimit Critical Closed
This issue duplicates:
FLUID-607 Uploading a large file fails, no feedback given. Major Closed
This issue relates to:
FLUID-1812 [Uploader 2] When adding a file fails, the file total area updates even though nothing is added Major Closed

Activity

Ascending order - Click to sort in descending order
Hide
Permalink
Eli Cochran added a comment -
Added error messages for when a file queue fails.

Please note that there is some strange behavior in SWFUpload:
if the limit on the number of files that can be uploaded is 3 and the user attempts to select 4 files, instead of queing the first 3 files and then throwing an error, SWFUpload just throws an error and no files are queued. Fun!
Show
Eli Cochran added a comment - Added error messages for when a file queue fails. Please note that there is some strange behavior in SWFUpload: if the limit on the number of files that can be uploaded is 3 and the user attempts to select 4 files, instead of queing the first 3 files and then throwing an error, SWFUpload just throws an error and no files are queued. Fun!
Hide
Permalink
Eli Cochran added a comment -
Forgot a few things in my check in:
- linting
- check in tests

Show
Eli Cochran added a comment - Forgot a few things in my check in: - linting - check in tests
Hide
Permalink
Justin Obara added a comment - - edited
In case this isn't part of the "check in tests" from the comment above, the Uploader unit tests are currently broken.
http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Uploader-test.html
Show
Justin Obara added a comment - - edited In case this isn't part of the "check in tests" from the comment above, the Uploader unit tests are currently broken. http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Uploader-test.html
Hide
Permalink
Eli Cochran added a comment -
I broke the tests when I failed to copy the HTML to the tests. Wondering if the tests should use AJAX to pull in the HTML the way that the Image Gallery does... wondering if that would even work.
Show
Eli Cochran added a comment - I broke the tests when I failed to copy the HTML to the tests. Wondering if the tests should use AJAX to pull in the HTML the way that the Image Gallery does... wondering if that would even work.
Hide
Permalink
Justin Obara added a comment -
I can't comment on whether or not this is the correct approach. I believe that the UI Options test may do this though ( http://build.fluidproject.org/infusion/tests/component-tests/uiOptions/html/UIOptions-test.html ). The side effect is that the stats for "x tests of y failed" and the time to complete, don't work.
Show
Justin Obara added a comment - I can't comment on whether or not this is the correct approach. I believe that the UI Options test may do this though ( http://build.fluidproject.org/infusion/tests/component-tests/uiOptions/html/UIOptions-test.html ). The side effect is that the stats for "x tests of y failed" and the time to complete, don't work.
Hide
Permalink
Eli Cochran added a comment -
Added basic unit tests and fixed some minor esthetic issues with IE
Show
Eli Cochran added a comment - Added basic unit tests and fixed some minor esthetic issues with IE
Hide
Permalink
Colin Clark added a comment -
Eli missed a stray line of code here that causes a global variable to be defined with SWFObject. Easy fix.
Show
Colin Clark added a comment - Eli missed a stray line of code here that causes a global variable to be defined with SWFObject. Easy fix.
Hide
Permalink
Colin Clark added a comment -
Bigger issues than I thought. On looking at this feature more closely, two show stoppers emerged:

1. The queue error dialog isn't implemented using jQuery UI's Dialog widget, so it lack a number of the keyboard accessibility fixes we added. As a result, focus is not captured within the dialog, and in fact moves directly behind the dialog.

2. There are no ARIA roles or states that would inform an AT user that this is an actual dialog.

We're not going to have a chance to implement fixes to these accessibility blockers before code freeze, so I've moved the code into a branch and removed the feature from trunk in preparation for the 1.1 release.
Show
Colin Clark added a comment - Bigger issues than I thought. On looking at this feature more closely, two show stoppers emerged: 1. The queue error dialog isn't implemented using jQuery UI's Dialog widget, so it lack a number of the keyboard accessibility fixes we added. As a result, focus is not captured within the dialog, and in fact moves directly behind the dialog. 2. There are no ARIA roles or states that would inform an AT user that this is an actual dialog. We're not going to have a chance to implement fixes to these accessibility blockers before code freeze, so I've moved the code into a branch and removed the feature from trunk in preparation for the 1.1 release.
Hide
Permalink
Anastasia Cheetham added a comment -
In testing for the 1.1 release, I still see this issue - there is no indication that an error occurred, other than the fact that the file doesn't show up in the queue.
Show
Anastasia Cheetham added a comment - In testing for the 1.1 release, I still see this issue - there is no indication that an error occurred, other than the fact that the file doesn't show up in the queue.
Hide
Permalink
Anastasia Cheetham added a comment -
I'll confirm this is still an issue for 1.3, multiple browsers/platforms.
Show
Anastasia Cheetham added a comment - I'll confirm this is still an issue for 1.3, multiple browsers/platforms.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated:
Atlassian JIRA (v4.4#649-r158309) | Report a problem
Powered by a free Atlassian JIRA open source license for The FLUID Project. Try JIRA - bug tracking software for your team.