Fluid Infusion

Eli Cochran added a comment - 19/May/09 3:21 AM Added error messages for when a file queue fails. Please note that there is some strange behavior in SWFUpload: if the limit on the number of files that can be uploaded is 3 and the user attempts to select 4 files, instead of queing the first 3 files and then throwing an error, SWFUpload just throws an error and no files are queued. Fun!

Eli Cochran added a comment - 19/May/09 9:44 AM Forgot a few things in my check in: - linting - check in tests

Justin Obara added a comment - 21/May/09 10:00 AM - edited In case this isn't part of the "check in tests" from the comment above, the Uploader unit tests are currently broken. http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Uploader-test.html

Eli Cochran added a comment - 21/May/09 5:52 PM I broke the tests when I failed to copy the HTML to the tests. Wondering if the tests should use AJAX to pull in the HTML the way that the Image Gallery does... wondering if that would even work.

Justin Obara added a comment - 22/May/09 9:11 AM I can't comment on whether or not this is the correct approach. I believe that the UI Options test may do this though ( http://build.fluidproject.org/infusion/tests/component-tests/uiOptions/html/UIOptions-test.html ). The side effect is that the stats for "x tests of y failed" and the time to complete, don't work.

Eli Cochran added a comment - 22/May/09 1:36 PM Added basic unit tests and fixed some minor esthetic issues with IE

Colin Clark added a comment - 25/May/09 3:28 PM Eli missed a stray line of code here that causes a global variable to be defined with SWFObject. Easy fix.

Colin Clark added a comment - 25/May/09 6:04 PM Bigger issues than I thought. On looking at this feature more closely, two show stoppers emerged: 1. The queue error dialog isn't implemented using jQuery UI's Dialog widget, so it lack a number of the keyboard accessibility fixes we added. As a result, focus is not captured within the dialog, and in fact moves directly behind the dialog. 2. There are no ARIA roles or states that would inform an AT user that this is an actual dialog. We're not going to have a chance to implement fixes to these accessibility blockers before code freeze, so I've moved the code into a branch and removed the feature from trunk in preparation for the 1.1 release.

Anastasia Cheetham added a comment - 29/May/09 3:22 PM In testing for the 1.1 release, I still see this issue - there is no indication that an error occurred, other than the fact that the file doesn't show up in the queue.