|
Forgot a few things in my check in:
- linting - check in tests In case this isn't part of the "check in tests" from the comment above, the Uploader unit tests are currently broken.
http://build.fluidproject.org/infusion/tests/component-tests/uploader/html/Uploader-test.html I broke the tests when I failed to copy the HTML to the tests. Wondering if the tests should use AJAX to pull in the HTML the way that the Image Gallery does... wondering if that would even work.
I can't comment on whether or not this is the correct approach. I believe that the UI Options test may do this though ( http://build.fluidproject.org/infusion/tests/component-tests/uiOptions/html/UIOptions-test.html ). The side effect is that the stats for "x tests of y failed" and the time to complete, don't work.
Added basic unit tests and fixed some minor esthetic issues with IE
Eli missed a stray line of code here that causes a global variable to be defined with SWFObject. Easy fix.
Bigger issues than I thought. On looking at this feature more closely, two show stoppers emerged:
1. The queue error dialog isn't implemented using jQuery UI's Dialog widget, so it lack a number of the keyboard accessibility fixes we added. As a result, focus is not captured within the dialog, and in fact moves directly behind the dialog. 2. There are no ARIA roles or states that would inform an AT user that this is an actual dialog. We're not going to have a chance to implement fixes to these accessibility blockers before code freeze, so I've moved the code into a branch and removed the feature from trunk in preparation for the 1.1 release. In testing for the 1.1 release, I still see this issue - there is no indication that an error occurred, other than the fact that the file doesn't show up in the queue.
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
 |
|
Bug
Reopened
Critical
[Uploader 2] When adding a file fails there is no user message
Please note that there is some strange behavior in SWFUpload:
if the limit on the number of files that can be uploaded is 3 and the user attempts to select 4 files, instead of queing the first 3 files and then throwing an error, SWFUpload just throws an error and no files are queued. Fun!